thaliMobile needs clean up native Android peer listeners when it declares a peer unavailable #1454

[opetkevich]

This change is 

[ThaliTester]

Test 111073062 (a55528a) build started.

[ThaliTester]

PR is added to the queue for testing as 1. task. (a55528a)

[ThaliTester]

Test (Fail) 111073062 build is completed (a55528a)

See https://github.com/ThaliTester/TestResults/tree/111073062a55528a_thaliMobile_needs_clean_up_native_Android_peer_listeners_when_it_declares_a_peer_unavailable__1454_opetkevich/ for the logs

[chapko]

-@chapko +@opetkevich

---

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

test/www/jxcore/bv_tests/testThaliMobile.js, line 2235 at r1 (raw file):

      ThaliMobile.stop().then(function () {
        t.equal(nativeDisconnectSpy.callCount, 1,
          'native wrapper `disconnect` called');

This test tests that after calling ThaliMobile.stop() it calls disconnect on the discovered peer.

There also should be a test, that tests disconnect call after receiving 'peer is not available' event.

Also I would add additional check for correct arguments (spy.calledWithExactly).

---

thali/NextGeneration/thaliMobile.js, line 1258 at r1 (raw file):

function changeCachedPeerUnavailable (peer) {
  removeAvailabilityWatcherFromPeerIfExists(peer);
  _this.disconnect(peer.peerIdentifier, peer.portNumber);

We usually use module.exports to access exported variables. Please, change it to module.exports.disconnect(...) for consistency.

---

thali/NextGeneration/thaliMobileNativeWrapper.js, line 814 at r1 (raw file):

  }
  return gPromiseQueue.enqueue(function (resolve, reject) {
    if(gServersManager !== null) {

NB: It probably would be more readable to use early return here.

if (!gServersManager) {
  return resolve();
}
...

---

Comments from Reviewable

[ThaliTester]

PR is added to the queue for testing as 1. task. (99e67f9)

[ThaliTester]

Test 111073062 (99e67f9) build started.

[ThaliTester]

Test (Fail) 111073062 build is completed (99e67f9)

See https://github.com/ThaliTester/TestResults/tree/11107306299e67f9_thaliMobile_needs_clean_up_native_Android_peer_listeners_when_it_declares_a_peer_unavailable__1454_opetkevich/ for the logs