Cast success to boolean in inventory report #925
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
success
fact (along with other Boolean RHSM facts, apparently) gets converted to a string at some point during Foreman/Katello processing. This caused problems for the Insights folks, so I'm raising this to ensure that it's cast back to a boolean value in the rh_cloud inventory report. This should produce reports that look like this:One other note - For source_os version and target_os version, if for some reason the host does not report that fact, I have a default value as
"Unknown - Fact not reported"
. (I needed to have a key/value pair there rather than omitting it entirely, because of some quirks about rh_cloud JSON which are discussed in #914 but really you probably don't want to know ;) Since that's also a string, I believe it should still comply with the schema outlined in https://github.com/RedHatInsights/inventory-schemas/pull/142/files. Let me know if that's a problem.