Fixes #17219 - bump squid3 to 1.0.2 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Take a look at thias/puppet-squid3#50 (which is still unmerged :/). Some of the Katello modules have dropped EL6 support, this one appears to have as well looking at the metadata.json so we should be fine. I will proceed once you get a chance to look at that PR. |
|
@ehelms I don't have a el6 to test if that persists, it doesn't seem to be fixed and the guy maintaining the module is quite bad with PRs ... :) in any case on el7 that dir is part of the squid package so I see no problem with merging this if the module has already dropped el6 support |
|
Agreed - thanks @timogoebel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ehelms in f461a21 you pinned it to 1.0.0 - but I don't really see why the updates should break el6 - in any case if the problem persists put this off till el6 support is dropped from katello :D
Greetings
Klaas