Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilded pull request from alank64 #10

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

linko
Copy link

@linko linko commented Apr 30, 2013

@linko
Copy link
Author

linko commented Apr 30, 2013

@therubymug, @alank64,

Will this work?

@linko
Copy link
Author

linko commented May 14, 2013

Any news on this?

@therubymug
Copy link
Owner

@linko sorry. I've been really busy the last few weeks! I looks like I may have some time towards the end of this week. :-)

@linko
Copy link
Author

linko commented Jun 5, 2013

I already use this code in one of my projects - works well.

@linko
Copy link
Author

linko commented Jun 26, 2013

@therubymug Still nothing?

@therubymug
Copy link
Owner

@linko sorry, your pull request only covers part of what my vision for what this feature is/should be. This is why I haven't merged this into master. Part of my virtus branch is aiming to do what you're doing in this pull request. I just have not had time (been busy with paid work) to finish that branch! Again, sorry about the delay it's just the way it goes sometimes. :-/

@alank64
Copy link

alank64 commented Jun 26, 2013

Rogelio,

Maybe others could contribute to your Virtus branch, like if you were to
outline the direction you want it to go, or the idea your aiming for.

This way we wouldn't waste effort on implementing things that your branch
changes and it would free you a little.

Keymaker is your baby, but just giving suggestions that might make it move
forward faster. ;)

On Wed, Jun 26, 2013 at 6:06 PM, Rogelio J. Samour <[email protected]

wrote:

@linko https://github.com/linko sorry, your pull request only covers
part of what my vision for what this feature is/should be. This is why I
haven't merged this into master. Part of my virtus branch is aiming to do
what you're doing in this pull request. I just have not had time (been busy
with paid work) to finish that branch! Again, sorry about the delay it's
just the way it goes sometimes. :-/


Reply to this email directly or view it on GitHubhttps://github.com//pull/10#issuecomment-20083778
.

@linko
Copy link
Author

linko commented Sep 16, 2013

Hey!

I'm using it in production already for about 5 months :) Maybe it's time to merge it? Only if it's a part of next big changes/updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants