updated country selector #10354
Open
updated country selector #10354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
requested changes
Dec 30, 2024
Comment on lines
+80
to
+83
| setEditedProfileDetails((prev) => { | ||
| const newState = { ...prev, [formName]: value }; | ||
| return newState; | ||
| }); |
There was a problem hiding this comment.
I don't think putting it on two lines is necessary
| search | ||
| value={editedProfileDetails?.country_iso2} | ||
| onChange={handleFormChange} | ||
| selected={editedProfileDetails?.country_iso2} |
There was a problem hiding this comment.
selected is not a supported property by CountrySelector. You should pass it as countryIso2
| @@ -102,13 +100,10 @@ export default function EditProfileForm({ | |||
| onChange={handleFormChange} | |||
| required | |||
| /> | |||
| <Form.Select | |||
| options={countryOptions} | |||
| <CountrySelector | |||
| label={i18n.t('activerecord.attributes.user.country_iso2')} | |||
There was a problem hiding this comment.
label is not a supported property by CountrySelector.
| value={editedProfileDetails?.country_iso2} | ||
| onChange={handleFormChange} | ||
| selected={editedProfileDetails?.country_iso2} | ||
| onChange={(event, data) => handleFormChange(null, { name: 'country_iso2', value: data.value })} |
There was a problem hiding this comment.
If you keep passing in name (not sure why you deleted that in the first place), then just keeping onChange={handleFormChange} should work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue, where we shouldn't allow multiple countries to be selected. To fix this I replaced the country selector of EditProfileForm with the existing CountrySelector.
Issue: #10283