Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SCA card number #5553

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Update SCA card number #5553

merged 1 commit into from
Jul 1, 2020

Conversation

viroulep
Copy link
Contributor

I'm not sure if they changed it or if I just missed the '2' in the documentation, but the previous card was supposed to ask for 3DS-2.
I changed it for the card number documented as requiring 3DS verification here.

Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried some other numbers from this table, but I missed it's not the one we're looking for ^^

The new error message is kinda weird, perhaps the iframe page uses Promises and the headless browser doesn't have it (nor there's a polyfill for it?) 🤔

@viroulep
Copy link
Contributor Author

Yeah our headless browser is way too old :(
I'm trying a polyfill in tests.

@viroulep viroulep force-pushed the update-sca-card branch 3 times, most recently from 8574c69 to 5d72807 Compare June 29, 2020 17:09
@viroulep
Copy link
Contributor Author

No clue why the polyfill failed :(

I've temporarily marked the tests as pending until we figure something out or we fix #5554.
I don't see much alternative since failing tests means no merge, even if the feature does work :s

Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this issue is quite frustrating, I agree it makes sense to skip these tests for now.

@jonatanklosko
Copy link
Member

jonatanklosko commented Jun 29, 2020

For the record: I think the problem is that the polyfills are not visible in iframes, where we'd actually need them. Poltergeist has an option to run some JS files to extend browser behavior, but that doesn't propagate to iframes either (teampoltergeist/poltergeist#703). Tried several other drivers (as per #5554), but apart from other numerous failures, I couldn't get this test to pass (due to other errors), so there's probably no straightforward solution :<

@viroulep viroulep merged commit f6f324e into thewca:master Jul 1, 2020
@viroulep viroulep deleted the update-sca-card branch July 1, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants