Socks5 support #709
Socks5 support #709
Conversation
|
Thanks for the pull request! It'd be great if you could provide tests for this feature. Check out |
|
I'm a bit confused about how to run existing tests for webkit. I couln't start any tests on my local machine, so I'm not sure how to write tests :( right now it says that there's no webkit-server file in repo. |
|
If you run If you'd like to just run individual tests, you can run |
|
@addicted2sounds I just wanted to check in and see if you're still interested in writing tests for this. |
|
Hi, yes, I'm interested but since I have no much time, I couldn't do them. I need to read documentation of how socks server responds and that inhibits me |
|
It looks I have no idea how to emulate socks proxy behaviour in tests. Could anyone help me? |
Conflicts: Gemfile.lock
Conflicts: Gemfile.lock spec/browser_spec.rb
| end | ||
| end | ||
| end | ||
| ======= |
There was a problem hiding this comment.
unexpected token tEQQ
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)
| port: "0", | ||
| user: "", | ||
| pass: "", | ||
| type: "http" |
There was a problem hiding this comment.
Put a comma after the last item of a multiline hash.
simple modifications for socks5 support