Remove deprecated functionality #801
Conversation
jferris
commented
Jun 26, 2015
jferris
commented
- Remove old, non-standard driver methods
- Remove non-global config methods
- Remove access to browser instance
- Remove support commands for removed methods
- Remove support for Qt 4
* Remove old, non-standard driver methods * Remove non-global config methods * Remove access to browser instance * Remove support commands for removed methods * Remove support for Qt 4
| gemfile: | ||
| - gemfiles/2.3.gemfile | ||
| - gemfiles/2.4.gemfile | ||
| before_install: | ||
| - sh -c 'if [ -n "$QMAKE" ]; then sudo apt-add-repository -y ppa:ubuntu-sdk-team/ppa && sudo apt-get update && sudo apt-get install libqt5webkit5-dev qtdeclarative5-dev; fi' | ||
| - sh -c 'sudo apt-add-repository -y ppa:ubuntu-sdk-team/ppa && sudo apt-get update && sudo apt-get install libqt5webkit5-dev qtdeclarative5-dev' |
There was a problem hiding this comment.
I think if we add qt5-default to this list, we should be able to omit the QMAKE environment variable on line 14.
This backwards-incompatible change brings our behavior in line with Selenium.
|
This looks great. I pushed up a few additional changes to the branch. As discussed in #652, we'll now raise an |
We don't support Qt 4 anymore.
mhoran
force-pushed
the
jf-remove-deprecated-behavior
branch
from
61a6dcc to
a2952d5
Compare
|
And what about global fonts overriding? I expected it to be removed when update to qt5 https://github.com/thoughtbot/capybara-webkit/blob/master/src/WebPage.cpp#L116 |
|
@amenzhinsky I opened #761 to handle fonts separately from the deprecated functionality. |
|
hey @jferris, Are there any plans about a release 2.0? |
I think we will likely release a 2.0 that removes deprecated functionality and is somewhat slimmer, but the main priority is currently to figure out what to do now that QtWebKit is deprecated. |
