fix(scan): handle "No: more data" error. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdb return "No: more data" string when the scan is finished. This commit handle it properly instead of logging an error.
|
I'm extremely uneasy with this. Back when I made this, matching on an exact string. Is this error part of the interface of 0-db? if not it might change at will and break 0-stor because of a patch update on a 0-db |
|
It is documented at the README https://github.com/threefoldtech/0-db?tab=readme-ov-file#scan if it changed, the only broken thing (for now) is the logging. |
LeeSmet
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zdb return "No: more data" string when the scan is finished. This commit handle it properly instead of logging an error.
Fixes #143