Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DEX orders on stellar client #119

Open
wants to merge 9 commits into
base: development
Choose a base branch
from
Open

Support DEX orders on stellar client #119

wants to merge 9 commits into from

Conversation

AlaaElattar
Copy link
Contributor

@AlaaElattar AlaaElattar commented Dec 5, 2024 •
edited
Loading

Description

  • support placing, canceling, and listing orders

Changes

  • Added createOrder, user can create buy/sell orders for specific assets.
  • Added cancelOrder, user can cancel specific order with its id.
  • Added getOrderBook, user can get oder book of the conversion between any 2 assets.
  • Added listMyOffers, user can list its offers.

Related Issues

#112

Checklist

  • Tests included
  • Build pass
  • Code format
  • Screenshots/Video attached (needed for UI changes)

@AlaaElattar AlaaElattar marked this pull request as draft December 5, 2024 10:56
@AlaaElattar AlaaElattar marked this pull request as ready for review December 22, 2024 15:32
zaelgohary
zaelgohary reviewed Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix analyze workflow. Also, can you replace prints with logger?

@AlaaElattar AlaaElattar marked this pull request as draft December 25, 2024 07:57
@AlaaElattar AlaaElattar marked this pull request as ready for review December 25, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaelgohary zaelgohary zaelgohary left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlaaElattar @zaelgohary