Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alternative text selection #10

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented May 21, 2024

Add the ability to provide an alternate selection as the basis of markdown actions. The specific use case here is to allow us to "quote" text that comes from outside our editor.

See: thunder-app/thunder#1374

qemu-system-x86_64_Y96wycow1v.mp4

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 514e371 into thunder-app:master Jun 4, 2024
1 check passed
@micahmo micahmo deleted the feature/quote-selection branch June 4, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants