Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create page markdown toolbar visibility #1581

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR potentially fixes an issue where the markdown toolbar is not visible when the keyboard is opened. I haven't been able to reproduce this issue myself, so this fix is a general guess and would have to be tested on an affected device.

The potential fix is to apply a margin equal to the keyboard's height for the toolbar, such that when the keyboard is open, the markdown toolbar is shifted up by the same amount. I've also set resizeToAvoidBottomInset to be false so that the scaffold does not automatically scale the page (which might potentially cause overflow issues that may hide the toolbar as well?)

@micahmo if you could just do a quick test on this on your device and let me know if the toolbar still shows up properly on your end, that would be great!

Issue Being Fixed

Issue Number: #1575

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it seems to work well!

@hjiangsu hjiangsu merged commit 15ff8b4 into develop Oct 22, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/create-post-comment-toolbar-visibility branch October 22, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants