Fix create page markdown toolbar visibility #1581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR potentially fixes an issue where the markdown toolbar is not visible when the keyboard is opened. I haven't been able to reproduce this issue myself, so this fix is a general guess and would have to be tested on an affected device.
The potential fix is to apply a margin equal to the keyboard's height for the toolbar, such that when the keyboard is open, the markdown toolbar is shifted up by the same amount. I've also set
resizeToAvoidBottomInset
to be false so that the scaffold does not automatically scale the page (which might potentially cause overflow issues that may hide the toolbar as well?)@micahmo if you could just do a quick test on this on your device and let me know if the toolbar still shows up properly on your end, that would be great!
Issue Being Fixed
Issue Number: #1575
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?