Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show URL on condensed post view #1604

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR adds the URL to link posts on the condensed post view. Only the host portion of the URL is shown rather than the full URL to keep it compact.

Issue Being Fixed

Issue Number: #1599

Screenshots / Recordings

Simulator Screenshot - iPhone 16 Plus - 2024-11-25 at 17 06 26 Simulator Screenshot - iPhone 16 Plus - 2024-11-25 at 17 06 50

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I love the implementation, looks great!

lib/post/widgets/post_view.dart Outdated Show resolved Hide resolved
@hjiangsu hjiangsu merged commit 9580cc0 into develop Nov 27, 2024
1 check passed
@hjiangsu hjiangsu deleted the feature/compact-post-view-url branch November 27, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants