CodeQL is reporting Pointless comparison of unsigned value to zero.

Signed-off-by: jasonc4 <[email protected]> Cc: Reviewer Aaron Pop <[email protected]> Cc: Reviewer Shruti Gupta <[email protected]>
tianocore · Nov 13, 2024 · 9a1d2ad · 9a1d2ad
1 parent 6bf2763
commit 9a1d2ad
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/Platform/Intel/MinPlatformPkg/Library/SerialPortTerminalLib/SerialPortTerminalLib.c b/Platform/Intel/MinPlatformPkg/Library/SerialPortTerminalLib/SerialPortTerminalLib.c
@@ -89,8 +89,7 @@ AddSerialTerminal (
       (int) mSerialDevicePath.Uart.StopBits,
       (int) DefaultTerminalType));
 
-  if (DefaultTerminalType >= 0 &&
-      DefaultTerminalType < (sizeof (mTerminalType) / sizeof (mTerminalType[0]))) {
+  if (DefaultTerminalType < (sizeof (mTerminalType) / sizeof (mTerminalType[0]))) {
     CopyMem (
       (VOID *) &(mSerialDevicePath.TerminalType.Guid),
       (VOID *) mTerminalType[DefaultTerminalType],