ManageabilityPkg: Add TransportLib instance for IPMI Serial #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gtossk2, thanks for this contribution. Lets split this commit into three first. It would give us a clear picture of introducing the serial port interface to edk2 manageability package.
|
gtossk2
force-pushed
the
ManageabilityTransportSerialLib
branch
from
17064b9 to
d94794a
Compare
|
Hi @changab Thanks for the suggestion. I have split the commits into three. Please kindly let me know if it is what you expected. Thanks! |
gtossk2
force-pushed
the
ManageabilityTransportSerialLib
branch
from
d94794a to
028a2a0
Compare
changab
reviewed
Nov 18, 2024
...nageabilityPkg/Library/ManageabilityTransportSerialLib/Common/ManageabilityTransportSerial.h
Outdated
Show resolved
Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c
Outdated
Show resolved
Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c
Outdated
Show resolved
Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c
Outdated
Show resolved
Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c
Outdated
Show resolved
Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c
Outdated
Show resolved
Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c
Show resolved
Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c
Show resolved
Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c
Outdated
Show resolved
Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c
Outdated
Show resolved
Hide resolved
gtossk2
force-pushed
the
ManageabilityTransportSerialLib
branch
from
028a2a0 to
736fd16
Compare
gtossk2
force-pushed
the
ManageabilityTransportSerialLib
branch
from
736fd16 to
387ab12
Compare
abdattar
requested changes
Nov 22, 2024
...nageabilityPkg/Library/ManageabilityTransportSerialLib/Common/ManageabilityTransportSerial.h
Outdated
Show resolved
Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c
Outdated
Show resolved
Hide resolved
.../ManageabilityPkg/Library/ManageabilityTransportSerialLib/Dxe/ManageabilityTransportSerial.c
Outdated
Show resolved
Hide resolved
.../ManageabilityPkg/Library/ManageabilityTransportSerialLib/Dxe/ManageabilityTransportSerial.c
Show resolved
Hide resolved
.../ManageabilityPkg/Library/ManageabilityTransportSerialLib/Dxe/ManageabilityTransportSerial.c
Outdated
Show resolved
Hide resolved
gtossk2
force-pushed
the
ManageabilityTransportSerialLib
branch
from
387ab12 to
aa14915
Compare
|
@abdattar Many thanks for the review. I have updated per your comments. |
abdattar
requested changes
Nov 25, 2024
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c
Show resolved
Hide resolved
gtossk2
force-pushed
the
ManageabilityTransportSerialLib
branch
from
aa14915 to
1b35f66
Compare
abdattar
reviewed
Nov 26, 2024
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c
Show resolved
Hide resolved
|
code changes looks good to me. |
abdattar
reviewed
Nov 26, 2024
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c
Show resolved
Hide resolved
gtossk2
force-pushed
the
ManageabilityTransportSerialLib
branch
from
1b35f66 to
4c443b1
Compare
abdattar
approved these changes
Nov 27, 2024
ManageabilityTransportSerialLib instance following the manageability transport framework to support IPMI Serial protocol. Data structure refer to Figure 14, IPMI 2.0. Signed-off-by: John Chung <[email protected]>
This introduces ManageabilityTransportSerial in manageability help library. Signed-off-by: John Chung <[email protected]>
This introduces serial protocol in IPMI driver. Signed-off-by: John Chung <[email protected]>
gtossk2
force-pushed
the
ManageabilityTransportSerialLib
branch
from
4c443b1 to
3e28a2e
Compare
changab
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ManageabilityTransportSerialLib instance following the manageability transport framework to support IPMI Serial protocol.