CodeQL is reporting Pointless comparison of unsigned value to zero. #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jasonc4 <[email protected]> Cc: Reviewer Aaron Pop <[email protected]> Cc: Reviewer Shruti Gupta <[email protected]>
v-jaschen
requested review from
ChaselChiu,
nate-desimone and
SaiChaganty
as code owners
6 tasks
apop5
added a commit
to microsoft/mu_common_intel_min_platform
that referenced
this pull request
Nov 14, 2024
#311) ## Description Cherry-pick Commit 03664aa #282 from release/202311 to dev/202405. CodeQL is reporting Pointless comparison of unsigned value to zero for a value derived from an unsigned PCD PcdDefaultTerminalType. For details on how to complete these options and their meaning refer to [CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md). - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? - [X] Backport to release branch? ## How This Was Tested Ran Local CI including codeQL setting and pipeline codeQL build. ## Integration Instructions N/A ## upstream repo in EDK2? tianocore/edk2-platforms#246 Co-authored-by: Aaron <[email protected]> Co-authored-by: Aaron <[email protected]>
ProjectMuBot
pushed a commit
to microsoft/mu_common_intel_min_platform
that referenced
this pull request
Nov 14, 2024
#311) ## Description Cherry-pick Commit 03664aa #282 from release/202311 to dev/202405. CodeQL is reporting Pointless comparison of unsigned value to zero for a value derived from an unsigned PCD PcdDefaultTerminalType. For details on how to complete these options and their meaning refer to [CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md). - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? - [X] Backport to release branch? ## How This Was Tested Ran Local CI including codeQL setting and pipeline codeQL build. ## Integration Instructions N/A ## upstream repo in EDK2? tianocore/edk2-platforms#246 Co-authored-by: Aaron <[email protected]> Co-authored-by: Aaron <[email protected]>
|
Hi, review-requested: @ChaselChiu @nate-desimone @SaiChaganty @lgao4 @ydong10 Please kindly help me to review it. Thanks |
ChaselChiu
approved these changes
Nov 15, 2024
SaiChaganty
approved these changes
Nov 15, 2024
|
My apology @ChaselChiu , I pressed a wrong button to request you review again. :( |
ChaselChiu
approved these changes
Nov 15, 2024
|
Since I don't have the permission to merge my code change to master branch. Could someone help to do a code merge on it? Thank you very much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeQL is reporting Pointless comparison of unsigned value to zero.
Signed-off-by: jasonc4 [email protected]
Cc: Reviewer Aaron Pop [email protected]
Cc: Reviewer Shruti Gupta [email protected]
How This Was Tested
Ran Local CI including codeQL setting and pipeline codeQL build.
Integration Instructions
N/A