Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSLA-6447] Remove unused Azure AD delegated permission #1365

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

jaderhs
Copy link
Contributor

@jaderhs jaderhs commented Mar 11, 2024

The Directory.Read.All Azure AD delegated permission is not required for Azure AD integration anymore.

Product Version(s):

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 3cdc182
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/65eed0badcfdc70008d0b9ea
😎 Deploy Preview https://deploy-preview-1365--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 67 (🟢 up 9 from production)
Accessibility: 93 (no change from production)
Best Practices: 92 (no change from production)
SEO: 79 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3cdc182
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/65eed0ba4d11a60008a8b1af
😎 Deploy Preview https://deploy-preview-1365--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaderhs jaderhs marked this pull request as ready for review March 11, 2024 11:32
@jaderhs jaderhs requested a review from a team as a code owner March 11, 2024 11:32
@jaderhs jaderhs changed the title Remove unused Azure AD delegated permission [TSLA-6447] Remove unused Azure AD delegated permission Mar 11, 2024
@ctauchen
Copy link
Collaborator

Lgtm. Ready to merge?

@jaderhs
Copy link
Contributor Author

jaderhs commented Mar 11, 2024

Lgtm. Ready to merge?

Yes

@ctauchen ctauchen merged commit bb6f27b into tigera:main Mar 11, 2024
10 checks passed
@jaderhs jaderhs deleted the tsla-6447-remove-unused-ad-permission branch March 11, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants