Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH#1102: Fix spelling errors #1383

Merged
merged 54 commits into from
Mar 27, 2024
Merged

GH#1102: Fix spelling errors #1383

merged 54 commits into from
Mar 27, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Mar 21, 2024

Product Version(s):
Calico (3.25, 3.26, 3.27), Calico Enterprise (3.16, 3.17, 3.18, 3.19), and Calico Cloud (3.19)

Issue:
#1102

(Repost of #1103)

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@jsoref jsoref requested a review from a team as a code owner March 21, 2024 05:43
@netlify Netlify
Copy link

netlify bot commented Mar 21, 2024 •
edited
Loading

✅ Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit d0e3ae7
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/6603718f4102730008221afb
😎 Deploy Preview https://deploy-preview-1383--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 66 (🟢 up 3 from production)
Accessibility: 93 (no change from production)
Best Practices: 92 (no change from production)
SEO: 79 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Mar 21, 2024 •
edited
Loading

✅ Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit d0e3ae7
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/6603718fd621da000805c716
😎 Deploy Preview https://deploy-preview-1383--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 69 (🔴 down 3 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jsoref jsoref force-pushed the spelling branch 3 times, most recently from 8d9808c to 56554fc Compare March 21, 2024 06:21
jsoref
jsoref commented Mar 21, 2024
View reviewed changes
calico-cloud/reference/resources/securityeventwebhook.mdx
| value | Direct value for the variable. | string | yes if `valueFrom` is not specifed |
| valueFrom | Value defined either in a Kubernetes ConfigMap or in a Kubernetesa Secret. | [SecurityEventWebhookConfigVarSource](#securityeventwebhookconfigvarsource) | yes if `value` is not specified |
| value | Direct value for the variable. | string | yes if `valueFrom` is not specified |
| valueFrom | Value defined either in a Kubernetes ConfigMap or in a Kubernetes Secret. | [SecurityEventWebhookConfigVarSource](#securityeventwebhookconfigvarsource) | yes if `value` is not specified |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some of these tables, I've tried to maintain columns. For some, I have given up. But I can add commits to fix things up if requested.

@ctauchen
Copy link
Collaborator

LGTM, thanks! I'm showing merge conflicts. Can you rebase, sort those out, and we can merge?

jsoref added 21 commits March 26, 2024 21:08
@jsoref
spelling: access
82217fc 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: account
aa4e91a 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: administrators
2f5d6fc 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
whitespace: aggregation
0cc0d4e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: anymore
04a4279 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: associate
8ab36f7 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: calicoctl
1a8d5c0 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: cannot
acdac19 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: case-insensitive
334fe34 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: conntrack
8c03635 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: dashboard
75f4397 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: default
6c3bbf3 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: detection
a26f218 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
whitespace: detection
9eb20a4 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: docusaurus
d89f3be 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: drop
57a0163 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: enterprise
6fc96cb 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: env
989ee03 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: examined
2dc6646 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: explicitly
1b2896d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: github
1d12d6b 
Signed-off-by: Josh Soref <[email protected]>
jsoref added 25 commits March 26, 2024 21:08
@jsoref
spelling: kubernetes
c65009c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: loadbalancer
2a4dd9f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: macos
455b0dd 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: maintenance
3f02bd8 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: nelljerram
a67d610 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: nonexistent
24914e2 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: openstack
c8201f5 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: overridden
11bb674 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: partner
1d8d338 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: policies
61fdd2f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: preexisting
ca42697 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: prefix
83047fd 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: rapidly
30ca110 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: running
d94dc67 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: separately
78c9ef1 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: specified
835b640 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: style
a925726 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: support
e8fde2f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
whitespace: successfully
0d8cafd 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: suspicious
b0618f9 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: than
85db462 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: this
1b470a7 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: typescript
bd468fd 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
whitespace: unknown
0b289bb 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: updating
d0e3ae7 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Copy link
Contributor Author

jsoref commented Mar 27, 2024

@ctauchen: done

@ctauchen
Copy link
Collaborator

LGTM thanks!

@ctauchen ctauchen merged commit fdb9a00 into tigera:main Mar 27, 2024
9 of 10 checks passed
@jsoref jsoref deleted the spelling branch March 27, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctauchen ctauchen ctauchen left review comments

@coutinhop coutinhop coutinhop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoref @ctauchen @coutinhop