Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml key and bare-metal index #1782

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

hjiawei
Copy link
Contributor

@hjiawei hjiawei commented Nov 21, 2024

This change fixes the certificate-authority-data key for kubeconfig in the bare-metal doc. It also revert the index.mdx changes from [1].

[1] https://github.com/tigera/docs/pull/1758/files#diff-cee12842f2d30c31655cc9f7e40e9b74e3e89c147e8568e7023c6a298cca6fe3

Product Version(s):

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

This change fixes the `certificate-authority-data` key for kubeconfig
in the bare-metal doc. It also revert the `index.mdx` changes from [1].

[1] https://github.com/tigera/docs/pull/1758/files#diff-cee12842f2d30c31655cc9f7e40e9b74e3e89c147e8568e7023c6a298cca6fe3
@hjiawei hjiawei requested a review from a team as a code owner November 21, 2024 20:37
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0163bfc
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/673f9a07fa616b00086ca938
😎 Deploy Preview https://deploy-preview-1782--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27 (🔴 down 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 0163bfc
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/673f9a07f7926a0008fad4c5
😎 Deploy Preview https://deploy-preview-1782--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctauchen
Copy link
Collaborator

LGTM, thanks for the fixes

@ctauchen ctauchen merged commit 583e5ff into tigera:main Nov 22, 2024
10 checks passed
@hjiawei hjiawei deleted the fix-bare-metal-yaml-key-and-index branch November 22, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants