Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required steps for installing OSS Calico on Openshift v4.16+ on AWS #1820

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

coutinhop
Copy link
Member

Product Version(s):

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@coutinhop coutinhop requested a review from a team as a code owner December 19, 2024 20:04
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 3622f15
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/67660e98027b2800082bc5a7
😎 Deploy Preview https://deploy-preview-1820--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for tigera failed. Why did it fail? →

Built without sensitive environment variables

Name Link
🔨 Latest commit 3622f15
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/67660e98bec71a0008cc411d

Copy link
Collaborator

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with suggestions.

@coutinhop This PR covers OSS 3.28+. Am I right to assume this does not apply to 3.27? What about CE?

@coutinhop
Copy link
Member Author

LGTM, with suggestions.

@coutinhop This PR covers OSS 3.28+. Am I right to assume this does not apply to 3.27? What about CE?

Thanks @ctauchen and @radTuti ! I've addressed your comments. Yes, this doesn't apply to v3.27 as the product changes to support OCP v4.16+ were only backported to v3.28+. The changes for Calico EE are still in flight, I'll change the docs once the product changes are merged.

@ctauchen
Copy link
Collaborator

LGTM

@ctauchen ctauchen merged commit af886d4 into tigera:main Dec 23, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants