-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 4401_ssrc_fog_x_tmotor mag0 prio #848
base: main
Are you sure you want to change the base?
Conversation
Param should be set as default so it is changeable by user. Further I propose setting it to a lower priority than external one. This makes the drone usable without external mag but will still prioritize the external one if it is installed
I don't think that MAG0 is always going to be internal. I have had situations where MAG0 was external mag. In short, I propose to remove the line that changes/sets the mag priority (CAL_MAGx_PRIO) altogether. |
The problem with magnetometer initialization order was fixed in #818 ; so the magnetometer ordering (which one is 0 and which one is 1) should stay. Now, the reason why the internal magnetometer is disabled on x500 airframe is, that the placement of saluki FC on our X500 setup causes too much disturbance on the mag from the power distribution board. This led to the issue that if there was any issue with the external magnetometer (the GPS stick), the internal one was taken into use without user noticing. But it didn't work well causing toiletbowling in the air. This was mitigated by disabling the internal magnetometer altogether when flying on the "hobby-grade" x500 setup, and using only external mag on that airframe. I'd suggest enabling the internal mag only in configurations where you know that it actually is usable. If you know that you actually can use the internal MAG on the T-motor airframe, it is indeed correct to just remove the line! Can you @kordets comment on what is your experience on internal mag on T-motor in outdoor flights, does it work ok? |
# Disable internal magnetometer | ||
param set CAL_MAG0_PRIO 0 | ||
# Low priority for internal magnetometer | ||
param set-default CAL_MAG0_PRIO 25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you commented, unless you want to disable the mag, just remove this line altogether.
Param should be set as default so it is changeable by user. Further I propose setting it to a lower priority than external one. This makes the drone usable without external mag but will still prioritize the external one if it is installed.