Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logger: fix file open issue if crypto algorithm is disabled #857

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

logger: fix file open issue if crypto algorithm is disabled #857

wants to merge 1 commit into from

Conversation

jnippula
Copy link

Create empty file even if crypto key is not stored into the beginning of the log file to allow file logger to always append log data into existing file.

@jnippula
logger: fix file open issue if crypto algorithm is disabled
9188888 
Create empty file even if crypto key is not stored into the beginning
of the log file to allow file logger to always append log data into
existing file.
@jnippula jnippula requested review from kordets and jlaitine December 27, 2024 10:23
jlaitine
jlaitine reviewed Dec 27, 2024
View reviewed changes
Copy link

@jlaitine jlaitine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit weird, is it so that the file might be created in two places?

jlaitine
jlaitine reviewed Dec 27, 2024
View reviewed changes
Copy link

@jlaitine jlaitine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is, should we really just push the key to the _buffers and let the file creation be only there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaitine jlaitine jlaitine left review comments

@kordets kordets Awaiting requested review from kordets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnippula @jlaitine