This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
Windows build files #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit message
Visual Studio, Windows SDK, CMake needed.
Poatgres folder has to be defined.
Look how TimescaleDB windows build is done,
should be similar as it is copied from there.
Tests not working.
Extra info
Windows build works quite same as TimescaleDB Windows build process.
After all dependencies needed are installed, bootstrap.bat will make the build folder and in Visual Studio it is possible to build and install from right clicking on CMakeLists.txt.
When building all in Visual Studio regressiontest will fail and I think regressioncheck was the 2nd one to fail. Build and install work fine.
Tests are copied from TimescaleDB, some of the files were removed that seemed not used for this dll, but I never got the time to work on tests.
in src/prom.c PGDLLEXPORT was needed for functions to get rid of
FATAL: could not find function "prom_in" in file ".../timescaledb.dll"Rest of the changes are mainly CMake files.
It was the PR I mentioned about making in #47