Skip to content

Add aggregation method parameter to Imputers #1015

Open
alex-hse-repository opened this issue Nov 25, 2022 · 0 comments
Open

Add aggregation method parameter to Imputers #1015

alex-hse-repository opened this issue Nov 25, 2022 · 0 comments
Labels
DKO enhancement New feature or request

Comments

@alex-hse-repository
Copy link
Collaborator

🚀 Feature Request

Add possibility to perform different kids of aggregation for seasonal strategy in TimeSeriesImputerTransform

Proposal

  1. In TimeSeriesImputerTransform add parameter aggregation_method: AggregationMode = "AggregationMode.mean -- method to aggregate values in the window (see link)
  2. Update method _fill to handle the logic with aggregation_method -- now it should aggregate values according the the passed method
    df.iloc[i] = np.nanmean(df.iloc[indexes])
  3. Update the docs

Test cases

Add test for the seasonal strategy which checks that it works correctly with different aggregation_method

Additional context

No response

@alex-hse-repository alex-hse-repository added enhancement New feature or request DKO labels Nov 25, 2022
@alex-hse-repository alex-hse-repository added this to the New Features milestone Nov 25, 2022
@alex-hse-repository alex-hse-repository moved this to Specification in etna board Nov 25, 2022
@alex-hse-repository alex-hse-repository moved this from Specification to Todo in etna board Nov 25, 2022
@Mr-Geekman Mr-Geekman moved this from Todo to Specification in etna board Jun 2, 2023
@Mr-Geekman Mr-Geekman removed this from the New Features milestone Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DKO enhancement New feature or request
Projects
Status: Specification
Development

No branches or pull requests

2 participants