refactor: use non deprecated type in eslint configuration #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove duplicated prettier configuration Signed-off-by: Jérôme Benoit <[email protected]>
AriPerkkio
reviewed
Oct 21, 2024
package.json
Outdated
| @@ -41,6 +41,7 @@ | |||
| "build": "tsup", | |||
| "publish": "clean-publish", | |||
| "lint": "eslint --max-warnings=0", | |||
| "lint:fix": "eslint --max-warnings=0 --fix", | |||
There was a problem hiding this comment.
This is a bit repetitive duplication of lint command.
With pnpm we can already do pnpm run lint --fix. I don't really see reason for adding new command just for one extra parameter.
AriPerkkio
reviewed
Oct 21, 2024
commit: |
AriPerkkio
approved these changes
Oct 21, 2024
AriPerkkio
requested changes
Oct 21, 2024
Signed-off-by: Jérôme Benoit <[email protected]>
AriPerkkio
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and remove duplicated prettier configuration