Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyRPL Bug Fix #400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TinyRPL Bug Fix #400

wants to merge 1 commit into from

Conversation

Hyungsin
Copy link

@Hyungsin Hyungsin commented Mar 20, 2017

I have evaluated TinyRPL for some years and found out some bugs, which cause malfunction.
This pull request is simply reporting these bugs.

  1. RPLDAORoutingEngineP.nc
  • A node must set "new_key" even when receiving a DAO from an existing entry, which enables to reset "path_lifetime". If not, each entry in the downlink routing table will be always removed after the initial path_lifetime.
  1. RPLOF0P.nc
  • Here, "min" value should be increased when a target entry is not a valid parent. However, the current "IF" conditions cannot tell if the entry is valid or not.
  1. RPLRankP.nc
  • "INIT_ETX" is not a pure ETX but ETX * divideRank. "tempEtx_hop" also has divideRank in it.
    So, we should replace "BLIP_L2_RETRIES" to BLIP_L2_RETRIES*divideRank for fairness.

@gnawali gnawali self-assigned this Mar 22, 2017
@Hyungsin
Copy link
Author

Any review?

@cire831
Copy link
Member

cire831 commented May 12, 2018

I don't have the expertise to review this. But ... have you tested this sufficiently?

How much testing have you done on this?

@Hyungsin
Copy link
Author

Hyungsin commented May 13, 2018

@gnawali
Copy link
Member

gnawali commented May 13, 2018

Not able to test but I will chat with you on Skype to go through the change one by one and then approve. Lets do it this week.

@Hyungsin
Copy link
Author

Ok. When is good for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants