Recovery #243
Recovery #243
Conversation
…ch breaks one previous test
…signLocal. Commented tests related to theses labels
…ule, hides label RParenTypelist
… tests related to this label
…hat insert labels
…l to 'parser.lua', following the output of the algorithm
…label RParenTypelist
…umber of some labels changed)
… (the last syntactic rule)
…t, which are used in predicates
…hod and key, new alternatives in simpletype)
There was a problem hiding this comment.
Looking superficially, I noticed that there are some "debug comments" that were committed by accident. I didn't list all of them to avoid being repetitive.
I didn't review the meat of the parser yet. I'll need to learn more about how that works first.
What is the purpose of the annotatedTitan.txt and annotatedTitanMet.txt files? They look like they were generated automatically.
| @@ -9,7 +9,7 @@ return function(prefix, types) | |||
| constructors[consname] = function(...) | |||
| local args = table.pack(...) | |||
| if args.n ~= #fields then | |||
| error("missing arguments for " .. consname) | |||
| error("missing arguments for " .. consname .. tostring(args.n) .. tostring(#fields)) | |||
There was a problem hiding this comment.
It seems that these were added for debugging but not remover later.
If we want to keep them they should have a space between the numbers at least.
| @@ -180,7 +180,9 @@ for _, keyword in ipairs(keywords) do | |||
| end | |||
|
|
|||
| lexer.NAME = Cmt(C(possiblename), function(_, pos, s) | |||
| --print('lexer', _, pos, s, is_keyword[s]) | |||
There was a problem hiding this comment.
These comments should be removed
| @@ -76,6 +96,9 @@ function defs.nil_exp(pos--[[, s ]]) | |||
| end | |||
|
|
|||
| function defs.number_exp(pos, n) | |||
| --print("number_exp", pos, n, math.type(n)) | |||
| --assert(n ~= 52) | |||
| --assert(n ~= '52') | |||
There was a problem hiding this comment.
More "debug" comments. Why is 52 important?
No description provided.