Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix library path for ppc64le #424

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix library path for ppc64le #424

wants to merge 2 commits into from

Conversation

lgbaldoni
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 21, 2017

Codecov Report

Merging #424 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #424      +/-   ##
=========================================
- Coverage    47.3%   47.3%   -0.01%     
=========================================
  Files         219     219              
  Lines       38796   38796              
=========================================
- Hits        18352   18351       -1     
- Misses      20444   20445       +1
Impacted Files Coverage Δ
libtizplatform/src/tizpqueue.c 86.16% <0%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee85809...dc9b2c0. Read the comment docs.

@juanrubio
Copy link
Member

juanrubio commented Dec 21, 2017

The latest version of the ax_boost_base.m4 is revision 43

So maybe the right thing to do would be to upgrade to that version in the various places where this macro is used in Tizonia:

./player/m4/ax_boost_base.m4:serial 23
./clients/chromecast/libtizchromecast/m4/ax_boost_base.m4:serial 25
./clients/youtube/libtizyoutube/m4/ax_boost_base.m4:serial 25
./clients/dirble/libtizdirble/m4/ax_boost_base.m4:serial 25
./clients/soundcloud/libtizsoundcloud/m4/ax_boost_base.m4:serial 25
./clients/gmusic/libtizgmusic/m4/ax_boost_base.m4:serial 25
./tools/tizonia-build/tizonia/player/m4/ax_boost_base.m4:serial 23
./tools/tizonia-build/tizonia/clients/chromecast/libtizchromecast/m4/ax_boost_base.m4:serial 25
./tools/tizonia-build/tizonia/clients/youtube/libtizyoutube/m4/ax_boost_base.m4:serial 25
./tools/tizonia-build/tizonia/clients/dirble/libtizdirble/m4/ax_boost_base.m4:serial 25
./tools/tizonia-build/tizonia/clients/soundcloud/libtizsoundcloud/m4/ax_boost_base.m4:serial 25
./tools/tizonia-build/tizonia/clients/gmusic/libtizgmusic/m4/ax_boost_base.m4:serial 25
./tools/tizonia-build/tizonia/rm/tizrmd/m4/ax_boost_base.m4:serial 23
./rm/tizrmd/m4/ax_boost_base.m4:serial 23

What do you think? Would that work for you? I can push that change to master later today.

@lgbaldoni
Copy link
Contributor Author

Tested and it works for me.

@juanrubio
Copy link
Member

Thanks for testing that. The macros have been updated in #426.

@lgbaldoni
Copy link
Contributor Author

I'm afraid I spoke too soon, now both ppc64 and ppc64le are broken.
Will try to investigate.

@tizonia tizonia requested a review from juanrubio April 2, 2018 09:20
@tizonia tizonia added the opensuse OpenSUSE packaging label Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opensuse OpenSUSE packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants