Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager): allow periods in package names #84

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

aarushtools
Copy link
Member

@aarushtools aarushtools commented Sep 18, 2024

Rationale

The package name regex does not allow periods in package names. However, some packages i.e. python3.12 have periods in them

Copy link
Member

@NotFish232 NotFish232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotFish232 NotFish232 merged commit 4879190 into tjcsl:master Oct 7, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants