Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility with Django 1.10 #64

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ma0c
Copy link

@ma0c ma0c commented Mar 16, 2017

Django 1.10 change the way to declare middleware but add a compatibility MiddlewareMixin to help the migrations. Also patterns was removed from django.conf.urls and django.conf.urls.defaults, and allows urlpatterns variable to be simple list. So, in case patterns functions is not found, we replace with a custom function that transforms the input args in a list.

@shacker
Copy link

shacker commented Jun 20, 2017

Can someone chime in on the status of this pull request, or recommend a fork of this project that is actively maintained?

@shacker
Copy link

shacker commented Jun 20, 2017

Hmm. I uninstalled the pip version and instead installed via
git+https://github.com/contraslash/django-subdomains
but am getting the same error against Django 1.11.

@shacker
Copy link

shacker commented Jun 20, 2017

Ah, this fork/fix does work with Django 1.11:
https://github.com/abe312/django-subdomains

@abe312
Copy link

abe312 commented Jun 24, 2017

yup! I uploaded the same to pypi under subdomains
so you could simply:
pip install subdomains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants