Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the nightly toolchain. #562

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

jrvanwhy
Copy link
Collaborator

@jrvanwhy jrvanwhy commented Nov 12, 2024

Code changes:

  1. A new lint was triggering on many of our CommandReturn::to_result invocations, indicating that we are relying on the implicit decay of ! into (). We should always make sure that only one success type matches when we invoke to_result, so this specifies the types.
  2. A lint now triggers in Miri for ignoring format!()'s possible error. We ignored it intentionally, so I make that explicit.
  3. A few tests incorrectly relied upon functions having stable addresses, which is not the case. This correctly those tests.
  4. Moved .cargo/config to .cargo/config.toml due to a new lint about the former being deprecated.

@jrvanwhy jrvanwhy added the upkeep Indicates a PR is upkeep as defined by the code review policy. label Nov 12, 2024
@jrvanwhy jrvanwhy marked this pull request as ready for review November 12, 2024 01:13
@jrvanwhy
Copy link
Collaborator Author

Both the stable and the nightly toolchains throw the following warning:

warning: failed to connect to jobserver from environment variable `MAKEFLAGS=" -j2 --jobserver-auth=3,4"`: cannot open file descriptor 3 from the jobserver environment variable value: Bad file descriptor (os error 9)

I've done some digging, and while I'm not 100% confident on this, I believe it is a result of a change in make (this PR doesn't even touch the stable toolchain). It seems like a future version of make (4.4?) may make this warning go away. This isn't failing the CI workflow so I'm planning to leave it as is.

If we want the warnings to go away, we'll have to use MAKEFLAGS= to disable jobserver integration (which is effectively disabled anyway), then clean it up later when make and rustc are playing nicely together again.

@jrvanwhy jrvanwhy added this pull request to the merge queue Nov 13, 2024
Merged via the queue into tock:master with commit a11c8d5 Nov 13, 2024
3 checks passed
@jrvanwhy jrvanwhy deleted the nightly-update branch November 13, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep Indicates a PR is upkeep as defined by the code review policy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants