-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Actions - Windows #352
base: master
Are you sure you want to change the base?
Conversation
bae9a1d
to
921b148
Compare
921b148
to
d72054d
Compare
I don't have a windows device or vm. Can someone update the tests to make sure they run? Also, do we want to support Windows? |
So it's just some completion tests that fail on Windows? It should be possible to fix that. Years ago, I've also used todo.sh on Windows / Cygwin, and I still remember that the tests succeeded back then. Extending the test coverage to Windows would be great; I think some folks have installed Cygwin just for that. I also don't have easy access to a Windows + Cygwin system any longer; maybe I'll still find some system. |
I was able to run the tests on a Microsoft Windows Server 2018 system (so actually quite close to the Windows 2019 used by the CI), with Cygwin 64-bit. All tests succeeded! Looking more closely, I think the CI is just using the Bash that's provided with Git, and the corresponding mingw32 tools (unfortunately, Bash doesn't identify itself, but I see For me, in the past, todo.sh on Windows always meant Cygwin. I'm not sure whether there's a Windows + Cygwin system available for CI; bootstrapping Cygwin each time doesn't sound attractive. On the other hand, mingw32 might be sufficient to run todo.sh (maybe with some adaptations to the tests); I think I can obtain another Windows VM with Git Bash; will check on Monday. |
Looking at the test for
|
Before submitting a pull request, please make sure the following is done:
master
.fixes #XX
reference to the issue that this pull request fixes.