Build: Tests: "make test" now fails if there are failing or broken tests #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggregate-results.sh just reports the execution status, but succeeds in all cases. The build should fail if there are errors. (This also means that no cleanup runs and the failures can be investigated in more detail.)
|
Kind of surprised that ShellCheck didn't catch the use of |
It's not parsed here (from --quiet, as in test-lib.sh), and even exporting it doesn't have any effect, as it's only used when say_color()'s first argument is invalid / empty, which cannot happen due to the defaulting in get_color().
|
@hyperupcall Thanks for reviewing! I have an older shellcheck 0.7.0 on the system that didn't catch the |
These make sense in the original context of testing Git commands (that may have external test scripts), but for todo.sh we've never used them, nor are they likely to be useful for this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aggregate-results.shjust reports the execution status, but succeeds in all cases.The build should fail if there are errors. (This also means that no cleanup runs and the failures can be investigated in more detail.)
Before submitting a pull request, please make sure the following is done:
master.$ make test, observe exit status 1fixes #XXreference to the issue that this pull request fixes.