Remove IntoResponse implementation for Option<T>

axum-core/src/response/into_response.rs

@@ -134,18 +134,6 @@ impl IntoResponse for Infallible {
     }
 }
 
-impl<T> IntoResponse for Option<T>
-where
-    T: IntoResponse,
-{
-    fn into_response(self) -> Response {
-        match self {
-            Some(v) => v.into_response(),
-            None => StatusCode::NO_CONTENT.into_response(),
-        }
-    }
-}
-
 impl<T, E> IntoResponse for Result<T, E>
 where
     T: IntoResponse,

axum/src/response/mod.rs

@@ -62,7 +62,7 @@ impl<T> From<T> for Html<T> {
 
 #[cfg(test)]
 mod tests {
-    use crate::extract::{Extension, Path};
+    use crate::extract::Extension;
     use crate::test_helpers::TestClient;
     use crate::{routing::get, Router};
     use axum_core::response::IntoResponse;
@@ -235,30 +235,4 @@ mod tests {
         let res = client.get("/unit").send().await;
         assert_eq!(res.status(), StatusCode::NO_CONTENT)
     }
-
-    #[tokio::test]
-    async fn test_option_http204_response() {
-        const SOMETHING: &str = "something";
-        async fn optional_value(Path(number): Path<usize>) -> Option<&'static str> {
-            if number % 2 == 0 {
-                None
-            } else {
-                Some(SOMETHING)
-            }
-        }
-
-        let app = Router::new().route("/optional/:number", get(optional_value));
-        let client = TestClient::new(app);
-        for i in 0..4 {
-            let url = format!("/optional/{i}");
-            let res = client.get(&url).send().await;
-            if i % 2 == 0 {
-                assert_eq!(res.status(), StatusCode::NO_CONTENT);
-                assert_eq!(res.text().await.len(), 0);
-            } else {
-                assert_eq!(res.status(), StatusCode::OK);
-                assert_eq!(res.text().await, SOMETHING);
-            }
-        }
-    }
 }