Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve crate-ci/typos configuration #3106

Merged
merged 5 commits into from
Dec 26, 2024
Merged

Improve crate-ci/typos configuration #3106

merged 5 commits into from
Dec 26, 2024

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Dec 26, 2024

see commit messages 😉

@jplatte
Copy link
Member

jplatte commented Dec 26, 2024

If both are supported (pretty sure they are), I'd prefer using .typos.toml over _typos.toml.

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 26, 2024

I just discovered that we could also use [workspace.metadata.typos] in the Cargo.toml file. I think that would me my preferred choice, unless you disagree

`_typos.toml` is used by default instead.
There don't appear to be any typos in our manifests, so we should be able to include them in the typo search.
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what to think of the config in Cargo.toml, really. For cargo plugins it makes sense to me, for more or less entirely language-agnostic tools like typos it feels a little weird. But it's nice to have one file less, I suppose.

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 26, 2024

for more or less entirely language-agnostic tools like typos it feels a little weird

huh, I guess I figured with the org name being crate-ci it was somewhat Rust-specific, but you're right, that there isn't much in it that is specific to Rust.

But it's nice to have one file less, I suppose.

yeah, even two files less in this case :D

@Turbo87 Turbo87 merged commit a5de589 into tokio-rs:main Dec 26, 2024
18 checks passed
@Turbo87 Turbo87 deleted the typos branch December 26, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants