Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: Merge config files #3108

Merged
merged 1 commit into from
Dec 26, 2024
Merged

clippy: Merge config files #3108

merged 1 commit into from
Dec 26, 2024

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Dec 26, 2024

The content of .clippy.toml was unintentionally overriding the contents of clippy.toml 😅

Related:

@jplatte
Copy link
Member

jplatte commented Dec 26, 2024

Nice. But let's use the dot-prefixed filename.

The content of `.clippy.toml` was unintentionally overriding the contents of `clippy.toml` 😅
@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 26, 2024

let's use the dot-prefixed filename.

done

@@ -1 +1,4 @@
allow-mixed-uninlined-format-args = false
disallowed-types = [
{ path = "tower::util::BoxCloneService", reason = "Use our internal BoxCloneService which is Sync" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reminds me, there is now https://docs.rs/tower/latest/tower/util/struct.BoxCloneSyncService.html that we may want to replace our own with.

@Turbo87 Turbo87 merged commit f6594aa into tokio-rs:main Dec 26, 2024
18 checks passed
@Turbo87 Turbo87 deleted the clippy branch December 26, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants