Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable glob path escape char on windows #132

Closed
wants to merge 3 commits into from

Conversation

Chrissi2812
Copy link
Contributor

According to the docs of the glob package windows style path separators are troublesome.

Note Glob patterns should always use / as a path separator, even on Windows systems, as \ is used to escape glob characters. If you wish to use \ as a path separator instead of using it as an escape character on Windows platforms, you may set windowsPathsNoEscape:true in the options. In this mode, special glob characters cannot be escaped, making it impossible to match a literal * ? and so on in filenames.

So I enabled the mentioned setting for the extract command. I'm not sure if it is also needed in the push.ts file.

Fixes #130

@JanCizmar JanCizmar requested a review from stepan662 December 3, 2024 10:51
src/extractor/runner.ts Outdated Show resolved Hide resolved
@stepan662
Copy link
Contributor

There is an issue with previous commit, I've reverted it, but yours is still above the old main.
So i've created new PR #133 which contains only your changes, so we can move forward.

@stepan662 stepan662 closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patterns don't work in tolgee.config.ts on Windows
3 participants