feat: align sync command with configuration schema
#139
+40
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gu-stav
force-pushed
the
feat/cli-sync-config
branch
from
9546c5d to
10fd107
Compare
gu-stav
changed the title
sync command with configuration schemasync command with configuration schema
gu-stav
force-pushed
the
feat/cli-sync-config
branch
from
10fd107 to
eb7ebaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the tolgee configuration with the
pushandpullcommands, which can either be configured through CLI options or a configuration file. Previously it was only possible to definesyncoptions via the CLI, but now it has it's own namespace in the tolgee configuration file.This is a first step towards implementing #137.
Documentation PR tolgee/documentation#792
Note: I haven't found any tests for
pushorpullfor using the configuration over the CLI options. Please let me know if there are any or whether you'd prefer me adding some.