Fix instructions for leak check on macOS. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's possible to add suppressions to Valgrind, making it ignore "static" leaks: https://valgrind.org/docs/manual/mc-manual.html#mc-manual.suppfiles |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while, but I wanted to "complete" my changes, and also automate memory-leak checking.
The instructions for running on macOS was outdated, as homebrew uses a different root folder now, so I've updated the instructions.
Unfortunately, running this locally results a non-zero exit code, which is unfortunate, as there's a github workflow for checking leaks.
I deliberately also deliberately pushed code that should leak to a test PR in my own space (it creates a
cgo.Handlethat it doesn't delete). But the build didn't catch this.Anyway, this PR is just about updating the readme file. Understanding the output of the leak check is a little outside my area of expertise.