Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support systemlessly deleting files or folders #6736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yujincheng08
Copy link
Collaborator

After we refactor the magic mount and always mount folder as tmpfs, we can easily support deleting files or folders now. We recognize dummy devices with major number 0 and minor number 0 as an indicator for removing files and folders. This indicator is borrowed from overlayfs.

@yujincheng08 yujincheng08 force-pushed the remove branch 5 times, most recently from 5edd8d9 to e2c45ca Compare March 13, 2023 07:46
@HuskyDG
Copy link
Contributor

HuskyDG commented Mar 13, 2023

We recognize dummy devices with major number 0 and minor number 0 as an indicator for removing files and folders. This indicator is borrowed from overlayfs.

Just a little thing, iirc overlayfs' whiteout indicator is character device node not block device node

@yujincheng08 yujincheng08 force-pushed the remove branch 2 times, most recently from a0eec0e to 6877232 Compare March 13, 2023 10:06
@yujincheng08 yujincheng08 added the core This issue is related to Magisk Core label Mar 15, 2023
@yujincheng08 yujincheng08 deleted the remove branch July 14, 2023 14:55
@osm0sis
Copy link
Collaborator

osm0sis commented Jul 21, 2023

Hopefully this one makes a return. Looked very cool. 🤞

After we refactor the magic mount and always mount folder as tmpfs,
we can easily support deleting files or folders now. We recognize
dummy devices with major number 0 and minor number 0 as an indicator
for removing files and folders. This indicator is borrowed from
overlayfs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This issue is related to Magisk Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants