Add support for additional S3-compatible providers #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 30 days with no activity. |
|
It's only stale because it hasn't been commented on by a maintainer |
|
This has been working stable for me for the past 1 year. i feel like this could be merged |
|
Hey, thanks for this patch! I've been playing with it, and to get it working with Ceph S3 you also need the This way, the bucket url is |
palvarez89
pushed a commit
to palvarez89/haste-server
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a backwards compatible change allowing people to use BackBlaze B2 or Linode with the aws-sdk (as they offer S3 endpoints).
The key change here is allowing an
endpointin the config instead of theregion. I've also added support for the credentials to be supplied via the config. This is optional, and if credentials are not specified in the config, it will fall back to the previous logic.