-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wagtail 6.0 #24
Wagtail 6.0 #24
Conversation
… 5.0 as they have reached EOL, Update changelog
…t python version, update setup.py
…min package, Add default value for STATIC_URL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 73.33% 73.68% +0.35%
==========================================
Files 5 5
Lines 75 76 +1
==========================================
+ Hits 55 56 +1
Misses 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Changes reviewed against Wagtail 6.0 upgrade requirements
- Code checked for Django 5.0 compatibility using django-upgrade
- General code review of changes
@katdom13 The changes here look good - just the one suggestion regarding the requirement bounds.
Django>=3.2 | ||
wagtail>=5.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: I think it would still be a good idea to restrict the upper versions here so that we're not claiming compatibility for future, possibly-breaking versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alxbridge ,
Thanks, I set the upperbound to 6.1: 720b2e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree. This is what nightly or weekly tests against Wagtail main should be for - pre-emptively finding failures.
In lots of cases, things will just work, so then you don't need to worry about making a new release. With this, we're increasing the maintenance burden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit 720b2e6.
Support Ticket
Wagtail 6.0 release notes
Summary of changes