Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 6.0 #24

Merged
merged 11 commits into from
Mar 11, 2024
Merged

Wagtail 6.0 #24

merged 11 commits into from
Mar 11, 2024

Conversation

katdom13
Copy link
Collaborator

@katdom13 katdom13 commented Mar 7, 2024

Support Ticket

Wagtail 6.0 release notes

Summary of changes

  • Added Wagtail 6.0 compatibility
  • Added tests for Django 5.0
  • Added tests for Python 3.12

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.68%. Comparing base (bce562a) to head (720b2e6).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   73.33%   73.68%   +0.35%     
==========================================
  Files           5        5              
  Lines          75       76       +1     
==========================================
+ Hits           55       56       +1     
  Misses         20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@alxbridge alxbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes reviewed against Wagtail 6.0 upgrade requirements
  • Code checked for Django 5.0 compatibility using django-upgrade
  • General code review of changes

@katdom13 The changes here look good - just the one suggestion regarding the requirement bounds.

Comment on lines +23 to +24
Django>=3.2
wagtail>=5.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: I think it would still be a good idea to restrict the upper versions here so that we're not claiming compatibility for future, possibly-breaking versions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alxbridge ,
Thanks, I set the upperbound to 6.1: 720b2e6

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree. This is what nightly or weekly tests against Wagtail main should be for - pre-emptively finding failures.

In lots of cases, things will just work, so then you don't need to worry about making a new release. With this, we're increasing the maintenance burden

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zerolab ,
Thanks for looking. I reverted it here:
a427c5e

@katdom13 katdom13 requested a review from alxbridge March 8, 2024 07:21
@zerolab zerolab mentioned this pull request Mar 8, 2024
@katdom13 katdom13 requested a review from zerolab March 8, 2024 10:43
@katdom13 katdom13 merged commit 2deac9c into torchbox:main Mar 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants