-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nextJSTypescriptTemplate #127
base: dev
Are you sure you want to change the base?
Conversation
hey, @dellorogiulio thanks for the contribution. I did a rebase taking as a reference the Let me ask, are you guys not using a docker-compose.yml file? |
Currently we are using no docker-compose, but I think that this should be fine version: "3.9"
services:
__container__-debug:
build:
context: .
dockerfile: Dockerfile.debug
image: ${LOCAL_REGISTRY}:5002/__container__-debug:${TAG}
ports:
- 2229:2229
- 9229:9229
- 9230:9230
- 9231:9231
__container__:
build:
context: .
dockerfile: Dockerfile
image: ${DOCKER_LOGIN}__container__:${TAG}
ports:
- 3000:3000 |
Hey @dellorogiulio I was testing here and trying to attach to the debugger but seems that something has been crashed on the Next JS side: vercel/next.js#55862 So, I will wait until they fix this. |
Hi @microhobby |
Next.js team worked on this issue and now it seems that this PR fixed it. |
Hi @microhobby |
Hey @escherstair we are in the process to release in this weekend a new version. I'm putting this to be reviewed in the next dev cycle. Thanks to point! |
Hi @microhobby |
Hi @escherstair and @dellorogiulio sorry for the delay. So, we will need to wait for this fix. Inside the container, we must set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for NextJS fix.
Hi @microhobby thank you... |
Hi @microhobby ,
i just prefered to create a new pull request instead of continuing the @escherstair one.
I decide to create the template for NextJS starting from the 'old'
pages
structure and not the 'new'src
directory. It can be easily changed in case.I tested the created container and runs with no problem on my module. I didn't test the Dockerfile.debug but I take it from the previous PR from @escherstair, so, should be fine.
I could miss something more related to torizonCore since I focus on the NextJS part, feel free to test scripts etc.