Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextJSTypescriptTemplate #127

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

dellorogiulio
Copy link

Hi @microhobby ,
i just prefered to create a new pull request instead of continuing the @escherstair one.
I decide to create the template for NextJS starting from the 'old' pages structure and not the 'new' src directory. It can be easily changed in case.
I tested the created container and runs with no problem on my module. I didn't test the Dockerfile.debug but I take it from the previous PR from @escherstair, so, should be fine.

I could miss something more related to torizonCore since I focus on the NextJS part, feel free to test scripts etc.

@dellorogiulio dellorogiulio changed the title Add nextJSTypescriptTemplate label:new-template Add nextJSTypescriptTemplate Oct 24, 2023
@microhobby microhobby self-requested a review October 24, 2023 21:31
@microhobby microhobby added the new-template Adding a new template label Oct 24, 2023
@microhobby microhobby changed the base branch from bookworm to dev October 26, 2023 01:34
@microhobby
Copy link
Collaborator

hey, @dellorogiulio thanks for the contribution. I did a rebase taking as a reference the dev branch which should be the branch to include new templates.

Let me ask, are you guys not using a docker-compose.yml file?

@dellorogiulio
Copy link
Author

Currently we are using no docker-compose, but I think that this should be fine

version: "3.9"
services:
  __container__-debug:
    build:
      context: .
      dockerfile: Dockerfile.debug
    image: ${LOCAL_REGISTRY}:5002/__container__-debug:${TAG}
    ports:
      - 2229:2229
      - 9229:9229
      - 9230:9230
      - 9231:9231


  __container__:
    build:
      context: .
      dockerfile: Dockerfile
    image: ${DOCKER_LOGIN}__container__:${TAG}
    ports:
      - 3000:3000

@microhobby
Copy link
Collaborator

Hey @dellorogiulio I was testing here and trying to attach to the debugger but seems that something has been crashed on the Next JS side: vercel/next.js#55862

So, I will wait until they fix this.

@escherstair
Copy link
Contributor

Hi @microhobby
they should have fixed with this PR (already merged)

@escherstair
Copy link
Contributor

Next.js team worked on this issue and now it seems that this PR fixed it.
It's in the canary branch and I think it will be included in the upcoming v14.0.5 release

@escherstair
Copy link
Contributor

Hi @microhobby
Next.js v14.1.0 has been released and it includes the fix.
Can you verify if now the Next.js Typescript Template works?

@microhobby
Copy link
Collaborator

Hey @escherstair we are in the process to release in this weekend a new version. I'm putting this to be reviewed in the next dev cycle. Thanks to point!

@microhobby microhobby added this to the v1.5.0 milestone Jan 26, 2024
@escherstair
Copy link
Contributor

Hi @microhobby
do you have news on the merge of this PR?
Thanks

@microhobby
Copy link
Collaborator

microhobby commented May 24, 2024

Hi @escherstair and @dellorogiulio sorry for the delay.
I tested it again and now with the latest NextJS version, but still no success trying to connect to the debugger node inspect. I opened a new issue there: vercel/next.js#66189

So, we will need to wait for this fix. Inside the container, we must set the NODE_OPTIONS='--inspect=0.0.0.0:9229' to be able to connect the debugger inside the container.

Copy link
Collaborator

@microhobby microhobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for NextJS fix.

@microhobby microhobby removed this from the v2.5.0 milestone May 24, 2024
@escherstair
Copy link
Contributor

escherstair commented May 27, 2024

Hi @microhobby thank you...
Sad to see that this feature is broken again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-template Adding a new template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants