Feature: async default value #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! LGTM. Please update changelog also. |
Pull Request Test Coverage Report for Build 8858936385Details
💛 - Coveralls |
YAGregor
added a commit
to YAGregor/tortoise-orm
that referenced
this pull request
Nov 3, 2023
|
I've done the change log, do you think we should update the doc? Seems that this behavior is natural, and there is no need to @long2ice |
YAGregor
added a commit
to YAGregor/tortoise-orm
that referenced
this pull request
Nov 6, 2023
YAGregor
force-pushed
the
feature-async-default-value
branch
from
567b31b to
246314f
Compare
|
@YAGregor hi! Please rebase PR on actual develop and resolve conflict in Changelog |
YAGregor
added a commit
to YAGregor/tortoise-orm
that referenced
this pull request
Apr 27, 2024
YAGregor
force-pushed
the
feature-async-default-value
branch
from
246314f to
b6864a2
Compare
abondar
reviewed
Apr 27, 2024
CHANGELOG.rst
Outdated
| @@ -1333,3 +1333,4 @@ Docs/examples: | |||
| await Tournament.filter( | |||
| events__name__in=['1', '3'] | |||
| ).order_by('-events__participants__name').distinct() | |||
| * Allow field's default keyword to be async function (#1498) | |||
There was a problem hiding this comment.
Seems like this entry is in wrong place
YAGregor
force-pushed
the
feature-async-default-value
branch
from
b6864a2 to
12b66d9
Compare
abondar
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow Field's default value not only be callable, literal value, but also async function
Description
when set Field's default keyword option to async function, then while save and create model, if the field never set, the field will be set as the async function's result
Motivation and Context
I write a model and I want a serial of unique, auto increasing serial names generate from redis (by aioredis), but the field's default do not support retrieve value from async function, I have to override create method, that's cumbersome.
and tortoise is an async orm, it should support async first.
How Has This Been Tested?
I create a new model for new test case, test model's behavior when combine async default with
save,create, and when default field value was covered by set attribute.I run tests on linux, include sqlite's test cases.
Almost no effect.
Checklist: