New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve type hints #1784

Merged

waketzheng merged 1 commit into tortoise:develop from waketzheng:improve-type-hints

Nov 24, 2024

Contributor

waketzheng commented Nov 22, 2024

Remove 3 type:ignore comments
Apply X|Y style which reduces import lines


          chore: improve type hints

384ba6a

coveralls commented Nov 24, 2024

Pull Request Test Coverage Report for Build 11976639446

Details

20 of 22 (90.91%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 89.509%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tortoise/init.py	20	22	90.91%

Totals
Change from base Build 11963373385:	-0.03%
Covered Lines:	6232
Relevant Lines:	6854

💛 - Coveralls

abondar approved these changes

View reviewed changes

waketzheng merged commit 1e6089d into tortoise:develop

7 checks passed

waketzheng deleted the improve-type-hints branch

December 27, 2024 02:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet