Add Postgres JSON filters #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12016619424Details
💛 - Coveralls |
2 tasks
abondar
reviewed
Nov 28, 2024
Comment on lines
+53
to
+73
| "gte": cast(Callable[..., Criterion], operator.ge), | ||
| "gt": cast(Callable[..., Criterion], operator.gt), | ||
| "lte": cast(Callable[..., Criterion], operator.le), | ||
| "lt": cast(Callable[..., Criterion], operator.lt), | ||
| "range": between_and, | ||
| "contains": contains, | ||
| "startswith": starts_with, | ||
| "endswith": ends_with, | ||
| "iexact": insensitive_exact, | ||
| "icontains": insensitive_contains, | ||
| "istartswith": insensitive_starts_with, | ||
| "iendswith": insensitive_ends_with, | ||
| "year": extract_year_equal, | ||
| "quarter": extract_quarter_equal, | ||
| "month": extract_month_equal, | ||
| "week": extract_week_equal, | ||
| "day": extract_day_equal, | ||
| "hour": extract_hour_equal, | ||
| "minute": extract_minute_equal, | ||
| "second": extract_second_equal, | ||
| "microsecond": extract_microsecond_equal, |
There was a problem hiding this comment.
Don't we need more test for all these new operators?
There was a problem hiding this comment.
@abondar there are tests in tests/contrib/postgres/test_json.py for all of these. Can you suggest any particular test cases you want me to add?
There was a problem hiding this comment.
Sorry, I am in wrong here, for some reason I only saw file with generic test_json, and didn't notice file with postgres-specific test_json
abondar
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
filterlookup types such asin,not_in,gt,lt, etc. This is based on changes from Additional Postgresql JSON Functions #1215TestJSONFieldswhich were disabled previously by mistake. Apparently if you stack@test.requireCapability(dialect="mysql")and@test.requireCapability(dialect="postgres")on top of each other, the test will not run for neither mysql or postgresModel.filter(data__filter={"names_0": "John"})Motivation and Context
JSON and JSONB fields are very popular with people who use Postgres. It makes sense to support a range of JSON operations. Django offers similar functionality.
Related issues:
How Has This Been Tested?
Added more tests and enabled the existing ones.
Checklist: