New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove duplicated code in postgres indexes #1805

Merged

waketzheng merged 1 commit into tortoise:develop from waketzheng:remove-duplicated-code

Dec 9, 2024

Contributor

waketzheng commented Dec 8, 2024

Description

Code of __init__ function in tortoise.contrib.postgres.indexes.PostgreSQLIndex is duplicated with its parent class PartialIndex

Motivation and Context

How Has This Been Tested?

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added the changelog accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.


          refactor: remove duplicated code in postgres indexes

31f6d1f

coveralls commented Dec 8, 2024

Pull Request Test Coverage Report for Build 12223386242

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 90.469%

Totals
Change from base Build 12203075077:	0.08%
Covered Lines:	6305
Relevant Lines:	6864

💛 - Coveralls

abondar approved these changes

View reviewed changes

waketzheng merged commit 3f0877d into tortoise:develop

7 checks passed

waketzheng deleted the remove-duplicated-code branch

December 27, 2024 02:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet