Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix deprecation warning for sphinx.testing.path #391

Closed
wants to merge 2 commits into from

Conversation

Mr-Pepe
Copy link
Contributor

@Mr-Pepe Mr-Pepe commented Oct 23, 2023

Fixes

tests/conftest.py:10
  .../sphinx-autodoc-typehints/tests/conftest.py:10: RemovedInSphinx90Warning: 'sphinx.testing.path' is deprecated. Use 'os.path' or 'pathlib' instead.
    from sphinx.testing.path import path

@Mr-Pepe Mr-Pepe marked this pull request as ready for review October 23, 2023 04:16
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI

@Mr-Pepe
Copy link
Contributor Author

Mr-Pepe commented Oct 26, 2023

os.path and pathlib are not drop-in replacements for sphinx.testing.path. Sphinx 7.2 dropped support for Python 3.8 and the last version that supports it (7.1) depends on specific functionality from sphinx.testing.path.

You can either drop support for Python 3.8 or close this PR and hope that Python 3.8 goes EOL before Sphinx 9.0 comes out and removes sphinx.testing.path 🤷

@Mr-Pepe Mr-Pepe removed their assignment Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants