Update dependencies, including upgrade to Cats Effect 3 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariolyon
force-pushed
the
master
branch
3 times, most recently
from
26e05ad to
ed54bae
Compare
|
Thanks! Looks like you're still working on this. Let me know when it's ready. |
|
Hi Rob,
thankyou! it's ready now, could you please review it?
I fiddled around with the scalafmt config a lot, to match the original
formatting as much as possible.
Mario
…On Fri, Apr 29, 2022 at 6:49 PM Rob Norris ***@***.***> wrote:
Thanks! Looks like you're still working on this. Let me know when it's
ready.
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACICCLAPPZVVHUWVUGRB76DVHQHKDANCNFSM5UVSRPAA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
|
@tpolecat do you have time to review the PR? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dependencies, including Cats Effect 3 which has many changes from Cats Effect 2.
This was my guide: https://typelevel.org/cats-effect/docs/migration-guide.
The PR also include a scalafmt config copied from the typelevel/cats-effect repo, so there are formatting changes.
The logger is also being created wherever it is used, which is the safer and clearer way
(https://typelevel.org/log4cats/#examples).
Overall, it's runnable, and it works like the original.