Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Traefik Proxy): add abortOnPluginFailure field #1251

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

bmagic
Copy link
Contributor

@bmagic bmagic commented Nov 13, 2024

What does this PR do?

This PR adds the new field abortOnPluginFailure (traefik/traefik#11228)

Motivation

Finish what I started in the first PR.

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

@bmagic bmagic force-pushed the abort-on-plugin-failure branch from 8355c0b to 7965528 Compare November 13, 2024 07:37
@bmagic bmagic marked this pull request as ready for review November 13, 2024 07:37
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR :-)
cf. my comments + let's wait for traefik to be released.

traefik/templates/_podtemplate.tpl Show resolved Hide resolved
@bmagic bmagic force-pushed the abort-on-plugin-failure branch from ea36482 to 498f46d Compare November 13, 2024 10:50
@mloiseleur mloiseleur changed the title Add abortOnPluginFailure field feat(Traefik Proxy): add abortOnPluginFailure field Nov 14, 2024
@bmagic
Copy link
Contributor Author

bmagic commented Nov 21, 2024

I'm waiting for #1259 to rebase and remove chart appversion in this test traefik/tests/deployment-config_test.yaml

@bmagic bmagic force-pushed the abort-on-plugin-failure branch 2 times, most recently from 29d145c to a1abfec Compare November 21, 2024 10:05
@bmagic bmagic requested a review from darkweaver87 November 21, 2024 10:05
@bmagic
Copy link
Contributor Author

bmagic commented Nov 21, 2024

I have rebased and removed the reference to the version in the test.

@mloiseleur mloiseleur added the kind/enhancement New feature or request label Nov 26, 2024
@traefiker traefiker merged commit b932958 into traefik:master Nov 26, 2024
1 check passed
@bmagic bmagic deleted the abort-on-plugin-failure branch November 26, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants