-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Traefik Proxy): add abortOnPluginFailure
field
#1251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmagic
force-pushed
the
abort-on-plugin-failure
branch
from
November 13, 2024 07:37
8355c0b
to
7965528
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR :-)
cf. my comments + let's wait for traefik to be released.
bmagic
force-pushed
the
abort-on-plugin-failure
branch
from
November 13, 2024 10:50
ea36482
to
498f46d
Compare
mloiseleur
changed the title
Add
feat(Traefik Proxy): add Nov 14, 2024
abortOnPluginFailure
fieldabortOnPluginFailure
field
I'm waiting for #1259 to rebase and remove chart appversion in this test traefik/tests/deployment-config_test.yaml |
bmagic
force-pushed
the
abort-on-plugin-failure
branch
2 times, most recently
from
November 21, 2024 10:05
29d145c
to
a1abfec
Compare
I have rebased and removed the reference to the version in the test. |
mloiseleur
force-pushed
the
abort-on-plugin-failure
branch
from
November 26, 2024 14:47
bf110bc
to
27d0b68
Compare
mloiseleur
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the new field
abortOnPluginFailure
(traefik/traefik#11228)Motivation
Finish what I started in the first PR.
More
make test
and all the tests passed